Birmingham | ITP-Sep-25 | Ahmad Ehsas | sprint 2 | Data groups by ahmadehsas · Pull Request #805 · CodeYourFuture/Module-Data-Groups

ahmadehsas · 2025-10-28T12:50:52Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I have completed all the required tasks.

Questions

…l the tets.

… tests cases.

…rray and passed the tests of given arrays.

…en tests.

…seNumber property.

…by join(\n) method.

github-actions · 2025-10-28T12:51:04Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-28T12:51:15Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-28T12:51:18Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-28T12:51:19Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-28T12:51:29Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-28T12:51:36Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

cjyuan · 2025-11-11T21:44:58Z

Title is not in the right format.
PR branch is not clean.

Can you address these issues?

github-actions · 2025-11-11T21:45:21Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-11T21:45:24Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

cjyuan · 2025-11-23T11:32:43Z

Sprint-2/debug/author.js

 for (const key in author) {
-  if (author.hasOwnProperty(key)) {
+ // if (author.hasOwnProperty(key)) {
    console.log(`${key}: ${author[key]}`);
  }
-}
+//}


Leaving commented out unused code can make code review difficult. Can you keep the the code clean by removing all unnecessary code?

I removed the unnecessary code.

cjyuan · 2025-11-23T11:37:34Z

Sprint-2/implement/contains.test.js

 test("contains on an array of length returns true", () => {
-  expect(contains([1, 2, 3, 4], "length")).toBe(true);
+  // expect(contains([1, 2, 3, 4], "length")).toBe(true);
+  expect(contains(null, "a", "length")).toBe(true);
 }); // the test returns true because 'length' is a property of the array object

 test("contains given on array as input return false", () => {
-  expect(contains([1, 2, 3], "a")).toBe(false);
+  // expect(contains([1, 2, 3], "a")).toBe(false);
+  expect(contains(1234, "a")).toBe(false);
 });


Do you expect the function to accept an array as its first parameter or not? These two test descriptions are contradicting each other.

The descriptions were unclear; the function does accept an array as the first parameter. I have now updated the descriptions.
I do apologise for my emojis; I just wanted to ensure I am looking for a solution to this review.

cjyuan · 2025-11-23T11:49:17Z

Sprint-2/interpret/invert.js

+// The current return value is {'1': 'a'}

 // b) What is the current return value when invert is called with { a: 1, b: 2 }
-// The current return value is {1: "a", 2: "b"}
+// The current return value is {'1': 'a', '2': 'b'}


These are still not the objects returned by the original (unmodified) function.

I have updated my code and answers

cjyuan · 2025-11-25T17:21:03Z

On some of the issues I commented, I don't see the changes I expected, and I am not good at guessing what the emoji reaction means. Can you respond to each of my comments with words?

cjyuan

You can use emojis, just not as a replacements for clear responses.

cjyuan · 2025-11-25T23:49:51Z

Sprint-2/implement/contains.test.js

+test("contains on array with existing property returns true", () => {
+ expect(contains([1, 2, 3, 4], "length")).toBe(true);
+}); 
+
+test("contains on array with non-existent property returns false", () => {
+  expect(contains(1234, "a")).toBe(false);
+});


Can you check carefully what could be improved?

Missing Given /When / Then style.

You have all the elements in the style your mentioned. So even without those words, your description still fit the style.

I was referring to something else. Is its something that you should "fix".

cjyuan · 2025-11-25T23:56:10Z

Sprint-2/interpret/invert.js

+// The current return value is {'1': 'a'}

 // b) What is the current return value when invert is called with { a: 1, b: 2 }
+// The current return value is {'1': 'a', '2': 'b'}



"Current return value" (in questions (a), (b), (d)) refers to the object returned by the original (unmodified) function -- the function before you modified it.

Can you update the answers to these three question accordingly?

cjyuan

Changes are good. Would be better if you also responded to each comment.

ahmadehsas added 16 commits July 28, 2025 15:16

Fixed the implementaton of the function CalculateMedian and passed al…

96e54cd

…l the tets.

Implemented the deduplicate function with given arrays and passed the…

d577680

… tests cases.

Implemented the function findMax and passed the tests for given arrays.

3ecbe9f

Implemented the function sum that sums the numerical elements of an a…

0467d03

…rray and passed the tests of given arrays.

Refactored the implementation of Includes function and passed the giv…

a9a5914

…en tests.

Fixed the code address object and used dot notation to access the hou…

d5ca4ab

…seNumber property.

Explained and fixed the problem in the mention code.

ce7733e

Fixed the mention code and printed out each ingredient in a new line …

73e8544

…by join(\n) method.

Implemented the function Contain, and passed tests for this function.

f512318

Implemented the createLookup function and passed the test.

22c4094

Fixed the implementation for this test and wrote tests.

1231d9c

Implemented the function called tally and passed tests.

aa42568

Fixed the implementation of invert function and wrote tests.

ef820ad

passed the test for contains of an array of length returns true.

898abfc

Fixed the code in one line with prettier-ignore.

2bc209b

fixed the test for given an array as input return false.

d0788b8

ahmadehsas added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 28, 2025

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 11, 2025

ahmadehsas added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 23, 2025

cjyuan reviewed Nov 23, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 23, 2025

ahmadehsas added 3 commits November 24, 2025 20:47

Removed unnecassary code to keep it clean.

28a4d76

Modified the discription of test cases on line 48 and 53.

da2a8c5

Fixed the code.

1cc69af

ahmadehsas added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 24, 2025

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 25, 2025

ahmadehsas added 3 commits November 25, 2025 21:51

removed unnecessary code.

954d882

updated the code.

99d8f1f

update the answer on line 39.

f0cfdc0

ahmadehsas added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 25, 2025

cjyuan reviewed Nov 25, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 25, 2025

ahmadehsas added 2 commits November 26, 2025 16:45

Updated the answers of question a, b and d.

ee378d5

Fixed contains.test.js.

f1c47e4

ahmadehsas added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 26, 2025

cjyuan reviewed Nov 27, 2025

View reviewed changes

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 27, 2025

ahmadehsas mentioned this pull request Nov 27, 2025

Birmingham | Data groups | Ahmad Ehsas ahmadehsas/My-Coursework-Planner#85

Open

illicitonion closed this Jan 7, 2026

Uh oh!

Conversation

ahmadehsas commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelist

Questions

Uh oh!

github-actions bot commented Oct 28, 2025

Uh oh!

github-actions bot commented Oct 28, 2025

Uh oh!

github-actions bot commented Oct 28, 2025

Uh oh!

github-actions bot commented Oct 28, 2025

Uh oh!

github-actions bot commented Oct 28, 2025

Uh oh!

github-actions bot commented Oct 28, 2025

Uh oh!

cjyuan commented Nov 11, 2025

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Nov 25, 2025

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ahmadehsas commented Oct 28, 2025 •

edited

Loading