Birmingham | ITP-Sep-25 | Ahmad Ehsas | sprint 2 | Data groups

Sprint-2/debug/author.js

@@ -18,10 +18,10 @@ const author = {
 // This means that we need to check if the property belongs to the object using hasownproperty whenever we loop through an object with the `for ... in` loop.
 
 for (const key in author) {
-  if (author.hasOwnProperty(key)) {
+ // if (author.hasOwnProperty(key)) {
     console.log(`${key}: ${author[key]}`);
   }
-}
+//}
 
 //for (const value of author) {
 // console.log(value);

Sprint-2/implement/contains.test.js

@@ -46,9 +46,11 @@ test("contains on an array returns false", () => {
 });
 
 test("contains on an array of length returns true", () => {
-  expect(contains([1, 2, 3, 4], "length")).toBe(true);
+  // expect(contains([1, 2, 3, 4], "length")).toBe(true);
+  expect(contains(null, "a", "length")).toBe(true);
 }); // the test returns true because 'length' is a property of the array object
 
 test("contains given on array as input return false", () => {
-  expect(contains([1, 2, 3], "a")).toBe(false);
+  // expect(contains([1, 2, 3], "a")).toBe(false);
+  expect(contains(1234, "a")).toBe(false);
 });

Sprint-2/implement/querystring.js

@@ -3,14 +3,18 @@ function parseQueryString(queryString) {
   if (queryString.length === 0) {
     return queryParams;
   }
+
   const keyValuePairs = queryString.split("&");
 
   for (const pair of keyValuePairs) {
-    const [key, value] = pair.split(/=(.+)/); // We use regex to split only at first.
+    const [key, value] = pair.split(/=(.*)/); // We use regex to split only at first.
     queryParams[key] = value;
+
   }
 
   return queryParams;
 }
+   console.log(parseQueryString("A="));
+   console.log(decodeURIComponent("id%3D5"));
 
 module.exports = parseQueryString;

Sprint-2/implement/tally.js

@@ -3,7 +3,7 @@ function tally(array) {
     throw new Error("Input must be an array");
     // check if the input ia an array. if not, throw an error.
   }
-  const tally = {};
+  const tally = Object.create(null);
 
   for (const item of array) {
     tally[item] = (tally[item] || 0) + 1;
@@ -12,8 +12,10 @@ function tally(array) {
   }
 
   return tally;
+
 }
 
 console.log(tally(["a", "a", "a"]));
+console.log(tally(["toString","toString"]));
 
 module.exports = tally;

Sprint-2/interpret/invert.js

@@ -20,10 +20,10 @@ console.log(invert({ a: 1, b: 2 })); // {1: "a", 2: "b"}
 module.exports = invert;
 
 // a) What is the current return value when invert is called with { a : 1 }
-// The current return value is {1: "a"}
+// The current return value is {'1': 'a'}
 
 // b) What is the current return value when invert is called with { a: 1, b: 2 }
-// The current return value is {1: "a", 2: "b"}
+// The current return value is {'1': 'a', '2': 'b'}
 
 // c) What is the target return value when invert is called with {a : 1, b: 2}
 // The target return value is {1: "a", 2: "b"}