Skip to content

fix: ListRow zebra striping #3201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codecademydev merged 5 commits into from
Nov 3, 2025
Merged

fix: ListRow zebra striping #3201

codecademydev merged 5 commits into from
Nov 3, 2025
+7 −1

Conversation

@dreamwasp
Copy link
Contributor

@dreamwasp dreamwasp commented Oct 30, 2025 •
edited
Loading

Overview

Fix semi-transparent layering in expandable rows

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: GM-219
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  1. Go to List
  2. Go to the ExpandableTableExample.
  3. Expand it and notices the row is the same color as its expanded drawer
  4. Go to the NonExpanded TableExample
  5. It looks normal
  6. Finish and do a celebratory dance

Other

The failing checks are happening because of my examples, I'll delete before shipping

PR Links and Envs

Repository PR Link
Mono Mono PR

@nx-cloud
Copy link

nx-cloud bot commented Oct 30, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 6a03bf0

☁️ Nx Cloud last updated this comment at 2025-11-03 15:27:38 UTC

dreamwasp
dreamwasp commented Oct 31, 2025
View reviewed changes
packages/styleguide/src/lib/Organisms/Lists & Tables/List/List.stories.tsx
args: { spacing: 'condensed', variant: 'table' },
render: (args) => <ListExample {...args} />,
};

Copy link
Contributor Author

@dreamwasp dreamwasp Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to delete these examples before shipping

@dreamwasp dreamwasp marked this pull request as ready for review October 31, 2025 16:03
@dreamwasp dreamwasp requested a review from a team as a code owner October 31, 2025 16:03
aresnik11
aresnik11 approved these changes Oct 31, 2025
View reviewed changes
Copy link
Contributor

@aresnik11 aresnik11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dreamwasp dreamwasp added Ship It :shipit: Automerge this PR when possible and removed Ship It :shipit: Automerge this PR when possible labels Nov 3, 2025
@codecademydev
Copy link
Collaborator

codecademydev commented Nov 3, 2025

📬 Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

🚀 Styleguide deploy preview ready!

Preview URL: https://6908cac843f71a7465a58315--gamut-preview.netlify.app
Deploy Logs: https://app.netlify.com/projects/gamut-preview/deploys/6908cac843f71a7465a58315

@dreamwasp dreamwasp added Ship It :shipit: Automerge this PR when possible and removed Ship It :shipit: Automerge this PR when possible labels Nov 3, 2025
@codecademydev codecademydev merged commit 85e2bdc into main Nov 3, 2025
21 of 26 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Nov 3, 2025
@codecademydev codecademydev deleted the cass-GM-219 branch November 3, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aresnik11 aresnik11 aresnik11 approved these changes

@jakemhiller jakemhiller Awaiting requested review from jakemhiller jakemhiller is a code owner automatically assigned from Codecademy/gamut

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dreamwasp @codecademydev @aresnik11