Skip to content

fix: ListRow zebra striping #3201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codecademydev merged 5 commits into from
Nov 3, 2025
+7 −1
Merged

fix: ListRow zebra striping #3201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c06e054
fix: ListRow zebra striping
dreamwasp Oct 30, 2025
83f6b42
format
dreamwasp Oct 30, 2025
aba5e54
alternating colors
dreamwasp Oct 30, 2025
188d02f
remove examples
dreamwasp Nov 3, 2025
6a03bf0
Merge branch 'main' into cass-GM-219
dreamwasp Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/gamut/src/List/ListRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ export const ListRow = forwardRef<HTMLLIElement, ListRowProps>(
c_sm: undefined,
}}
isOl={renderNumbering}
parentEl
role={role}
scrollable={scrollable}
tabIndex={tabIndex}
Expand Down
7 changes: 6 additions & 1 deletion packages/gamut/src/List/elements.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,12 @@ const rowStates = states({
display: 'flex',
flexDirection: { _: 'column', c_base: 'row', c_sm: 'column' },
},
/**
* Only the outermost element needs to inherit the background - otherwise it can stack with semitransparent bg colors and look off.
*/
parentEl: {
bg: 'inherit',
},
});

const interactiveState = states({
Expand Down Expand Up @@ -176,7 +182,6 @@ export interface RowProps
export const RowEl = styled('li', styledOptions<'li'>())<RowProps>(
css({
py: { _: 0, c_base: 8, c_sm: 0 },
bg: 'inherit',
width: 1,
}),
variance.compose(grid, flex),
Expand Down
Loading