Improved feed group UX #1108
Open
Improved feed group UX #1108
+257
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
girishpanchal30
added
the
pr-checklist-skip
pirate-bot
added
the
pr-checklist-complete
|
Plugin build for 665e37b is ready 🛎️!
Note You can preview the changes in the Playground |
| * @return void | ||
| */ | ||
| public function render_feed_preview() { | ||
| // phpcs:ignore WordPress.Security.NonceVerification.Recommended |
There was a problem hiding this comment.
You can use the https://developer.wordpress.org/reference/functions/check_ajax_referer/ to satisfy the linter.
There was a problem hiding this comment.
This function is used to render the feed preview in the sidebar. Since it's not an AJAX or form submission context, check_ajax_referer() doesn't apply.
|
@girishpanchal30, a rebase here when you can 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I have improved the feed group UX and added the default WP news group on activation.
Check before Pull Request is ready:
Closes https://github.com/Codeinwp/feedzy-rss-feeds-pro/issues/873