Fix quickinput standalone position #592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaisalmen
previously approved these changes
Mar 3, 2025
Collaborator
kaisalmen
left a comment
kaisalmen
left a comment
There was a problem hiding this comment.
Interesting, there aren't even any next builds. LGTM
CGNonofr
force-pushed
the
fix-standalone-quickinput-location
branch
from
685bf3a to
5b6d44b
Compare
Contributor
Author
|
@kaisalmen forgot to remove the import as well, wasn't building... |
kaisalmen
approved these changes
Mar 3, 2025
Collaborator
kaisalmen
left a comment
kaisalmen
left a comment
There was a problem hiding this comment.
LGTM once build is green.
|
🎉 This PR is included in version 14.0.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft doesn't seem to be releasing monaco-editor anymore 🤔
They broke the standalone quickinput location while implementing the ability to move it in the workbench
I'm not sure what is the proper fix to it, but at least that MR seems to be restoring the previous behavior