Skip to content

Fix quickinput standalone position #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CGNonofr merged 1 commit into from
Mar 3, 2025
Merged

Fix quickinput standalone position #592

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions vscode-patches/0062-fix-fix-standalone-editor-quick-input-location.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lo=C3=AFc=20Mangeonjean?= <loic@coderpad.io>
Date: Mon, 3 Mar 2025 15:10:33 +0100
Subject: [PATCH] fix: fix standalone editor quick input location

---
.../browser/quickInput/standaloneQuickInputService.ts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/vs/editor/standalone/browser/quickInput/standaloneQuickInputService.ts b/src/vs/editor/standalone/browser/quickInput/standaloneQuickInputService.ts
index 91f910e3776..ee712836bca 100644
--- a/src/vs/editor/standalone/browser/quickInput/standaloneQuickInputService.ts
+++ b/src/vs/editor/standalone/browser/quickInput/standaloneQuickInputService.ts
@@ -5,7 +5,7 @@

import './standaloneQuickInput.css';
import { Event } from '../../../../base/common/event.js';
-import { ICodeEditor, IOverlayWidget, IOverlayWidgetPosition, OverlayWidgetPositionPreference } from '../../../browser/editorBrowser.js';
+import { ICodeEditor, IOverlayWidget, IOverlayWidgetPosition } from '../../../browser/editorBrowser.js';
import { EditorContributionInstantiation, registerEditorContribution } from '../../../browser/editorExtensions.js';
import { IEditorContribution } from '../../../common/editorCommon.js';
import { IThemeService } from '../../../../platform/theme/common/themeService.js';
@@ -200,7 +200,7 @@ export class QuickInputEditorWidget implements IOverlayWidget {
}

getPosition(): IOverlayWidgetPosition | null {
- return { preference: OverlayWidgetPositionPreference.TOP_CENTER };
+ return { preference: null };
}

dispose(): void {