docs: add comment about update notification feature in coreping #111
Conversation
Add a comment noting the feature request for pinging when updates are made to previously-reviewed PRs. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds a comment documenting a feature request for notifying reviewers when previously-reviewed PRs receive updates. The comment is placed at the top of the coreping task file, which handles PR review reminders.
Key Changes
- Added informal comment about a feature request for pinging on PR updates
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import z from "zod"; | ||
| import { upsertSlackMessage } from "../gh-desktop-release-notification/upsertSlackMessage"; | ||
|
|
||
| // yeah, if the bot could ping when updates have been made to a previously-reviewed PR, would be extremely helpful |
There was a problem hiding this comment.
This comment lacks important context for a feature request. Consider using a more structured format that includes:
- A TODO or FEATURE label for tracking
- Who requested this feature or where it was discussed
- A brief description of what "previously-reviewed PR" means in this context
Example:
// TODO: Feature request - Add notification when updates are made to previously-reviewed PRs
// This would ping reviewers when a PR they've already reviewed receives new commits
// Requested by: [name/team] or tracked in issue #[number]This makes it easier to track and understand the feature request in the future.
| // yeah, if the bot could ping when updates have been made to a previously-reviewed PR, would be extremely helpful | |
| // TODO: Feature request - Notify reviewers when updates are made to previously-reviewed PRs |
| import z from "zod"; | ||
| import { upsertSlackMessage } from "../gh-desktop-release-notification/upsertSlackMessage"; | ||
|
|
||
| // yeah, if the bot could ping when updates have been made to a previously-reviewed PR, would be extremely helpful |
There was a problem hiding this comment.
The informal tone of this comment ("yeah, if the bot could...") is inconsistent with the professional documentation style used elsewhere in this file. Consider rephrasing to match the existing documentation standards, such as:
// Feature request: Enable pinging when updates are made to previously-reviewed PRs| // yeah, if the bot could ping when updates have been made to a previously-reviewed PR, would be extremely helpful | |
| // Feature request: Enable pinging when updates are made to previously-reviewed PRs |
Summary
Test plan
🤖 Generated with Claude Code