Skip to content

Conversation

@huchenlei
Copy link
Contributor

@huchenlei huchenlei commented Feb 28, 2025

  • Remove web/
  • Remove update-frontend.yml gh action
  • Add comfyui-frontend-package as pip dependency
  • Update frontend to v1.10.17

Ref: https://pypi.org/project/comfyui-frontend-package/

Changelog (1.10.0 - 1.10.17)

Features

BugFixes

Misc

@huchenlei huchenlei added the Frontend Issue relates to the frontend UI (litegraph). label Feb 28, 2025
@huchenlei huchenlei marked this pull request as draft February 28, 2025 19:25
@huchenlei huchenlei marked this pull request as ready for review February 28, 2025 19:39
@huchenlei huchenlei changed the title Use comfyui_frontend_package pypi package to manage frontend dependency Use comfyui_frontend_package pypi package to manage frontend dependency (Frontend v1.10.17) Feb 28, 2025
@comfyanonymous
Copy link
Member

I think the only thing missing is something that warns the user on startup if they have not updated the frontend pip package.

@huchenlei
Copy link
Contributor Author

huchenlei commented Feb 28, 2025

I think the only thing missing is something that warns the user on startup if they have not updated the frontend pip package.

Do we have an easy way to check the package version specified in requirement.txt? I think the desktop side has check on whether the pip environment satisfies the requirement.txt. Do we want to also bring that logic to the main repo?

@huchenlei
Copy link
Contributor Author

I think the only thing missing is something that warns the user on startup if they have not updated the frontend pip package.

Overall I think this should be a separate project. Users update via ComfyUI manager should automatically have the deps updated.

@comfyanonymous
Copy link
Member

At least there needs to be a warning if there is no frontend package installed to warn users who are doing update with git pull only.

@huchenlei
Copy link
Contributor Author

At least there needs to be a warning if there is no frontend package installed to warn users who are doing update with git pull only.

Done.

@mcmonkey4eva
Copy link
Contributor

Is --front-end-version cli arg still relevant to use, or is it entirely pip install @whatever now?

@huchenlei
Copy link
Contributor Author

Is --front-end-version cli arg still relevant to use, or is it entirely pip install @whatever now?

--front-end-version cli arg still works, but alternatively you can also pip install @whatever now.

@comfyanonymous comfyanonymous merged commit 04cf0cc into master Mar 2, 2025
6 checks passed
@huchenlei huchenlei deleted the frontend_package branch March 2, 2025 19:58
huchenlei added a commit to Comfy-Org/ComfyUI_frontend_setup_action that referenced this pull request Mar 2, 2025
@fofr
Copy link

fofr commented Mar 6, 2025

Will it be possible to run the API without comfyui-frontend-package?

@mcmonkey4eva
Copy link
Contributor

@huchenlei it looks like the CLI arg is being disregarded in favor of the pip package as mandatory 29832b3

Is it correct that the pip package is mandatory and updating versions of it is mandatory, or are the recent commits enforcing it in error and actually the CLI arg should suffice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Frontend Issue relates to the frontend UI (litegraph). Important

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants