Only check frontend package if using default frontend #7179
Conversation
huchenlei
requested review from
comfyanonymous,
ltdrdata,
pythongosssss,
robinjhuang,
webfiltered and
yoland68
as code owners
huchenlei
added
Frontend
robinjhuang
left a comment
robinjhuang
left a comment
There was a problem hiding this comment.
Tested and works on Desktop
| with open(req_path, "r", encoding="utf-8") as f: | ||
| required_frontend = parse_version(f.readline().split("=")[-1]) | ||
| if frontend_version < required_frontend: | ||
| logging.warning("________________________________________________________________________\nWARNING WARNING WARNING WARNING WARNING\n\nInstalled frontend version {} is lower than the recommended version {}.\n\n{}\n________________________________________________________________________".format('.'.join(map(str, frontend_version)), '.'.join(map(str, required_frontend)), frontend_install_warning_message())) |
There was a problem hiding this comment.
This warning needs to show up when the comfyui_frontend_package.version doesn't exist, it is for those who update and run comfyui manually in the console so it needs to be visible without scrolling up after launching comfyui.
There was a problem hiding this comment.
version("comfyui-frontend-package") will get the package version before when we expose it in 1.11.8.
There was a problem hiding this comment.
I can delay the execution of check_version to the original spot, but it breaks the overall execution flow.
Should we make a standard mechanism to delay every warning during startup after the server start log?
There was a problem hiding this comment.
yeah we should or else people will probably ignore them.
Ref: #7021 (comment)
The desktop app is also affected as it is currently shipping the frontend package twice, increasing the oveall disk space consumption for users.
This PR bypass the import of built-in frontend package and frontend version check if the user launches with
--front-end-rootor--front-end-versionargument to use alternative frontend implementation.