Skip to content

Conversation

@robinjhuang
Copy link
Member

@robinjhuang robinjhuang commented Mar 10, 2025

Adds ComfyUI branch with this commit:
Comfy-Org/ComfyUI#7179

  • Don't patch ComfyUI code anymore.
  • Continue to patch requirements so troubleshooting page is not triggered.

┆Issue is synchronized with this Notion page by Unito

@robinjhuang robinjhuang requested a review from a team as a code owner March 10, 2025 18:07
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 10, 2025
@robinjhuang robinjhuang marked this pull request as draft March 10, 2025 18:07
@dosubot dosubot bot added the dependencies label Mar 10, 2025
@robinjhuang robinjhuang changed the title Draft: remove patch and update FE dependencies Draft: Use ComfyUI branch with commit for ignoring FE pip package. Mar 11, 2025
@socket-security
Copy link

Report too large to display inline

View full report↗︎

@robinjhuang robinjhuang marked this pull request as ready for review March 11, 2025 18:56
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Mar 11, 2025
@robinjhuang robinjhuang changed the title Draft: Use ComfyUI branch with commit for ignoring FE pip package. Use ComfyUI branch with commit for ignoring FE pip package. Mar 11, 2025
@robinjhuang robinjhuang requested a review from webfiltered March 11, 2025 23:41
@robinjhuang
Copy link
Member Author

@webfiltered How does this look? I removed the patch for ComfyUI since we are using the PR HCL added. Still including the requirements.txt patch.

execAndLog(`yarn run download:uv all`);
execAndLog(`yarn run patch:core:frontend`);

/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/**
/**

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 12, 2025
@robinjhuang robinjhuang merged commit 4f17b10 into main Mar 12, 2025
7 checks passed
@robinjhuang robinjhuang deleted the rh-patch branch March 12, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants