Skip to content

Use ComfyUI branch with commit for ignoring FE pip package. #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robinjhuang merged 3 commits into from
Mar 12, 2025
Merged

Use ComfyUI branch with commit for ignoring FE pip package. #1044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cee5b66
Update compiled for windows.
robinjhuang Mar 10, 2025
9af934e
Remove patch.
robinjhuang Mar 10, 2025
4289c63
update
robinjhuang Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"frontendVersion": "1.10.18",
"comfyUI": {
"version": "0.3.26",
"optionalBranch": ""
"optionalBranch": "desktop-release-mar112025"
},
"managerCommit": "04fa540a8c09d890147fe158090d813be8d05d40",
"uvVersion": "0.5.31"
Expand All @@ -36,7 +36,7 @@
"make:nvidia": "yarn run make -- --nvidia",
"notarize": "node debug/notarize.js",
"package": "yarn run vite:compile && todesktop build --code-sign=false --async",
"patch:core:frontend": "node scripts/patchComfyUI.js frontend requirements",
"patch:core:frontend": "node scripts/patchComfyUI.js requirements",
"postinstall": "node .husky/install.mjs",
"publish": "yarn run vite:compile && todesktop build",
"publish:staging": "yarn run vite:compile && todesktop build --config=./todesktop.staging.json --async",
Expand Down
1 change: 0 additions & 1 deletion scripts/makeComfy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ execAndLog(
execAndLog(`yarn run make:frontend`);
execAndLog(`yarn run download:uv all`);
execAndLog(`yarn run patch:core:frontend`);

/**
Copy link
Contributor

@webfiltered webfiltered Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/**
/**

* Run a command and log the output.
* @param {string} command The command to run.
Expand Down
7 changes: 0 additions & 7 deletions scripts/patchComfyUI.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,6 @@ import fs from 'node:fs/promises';
* ```
*/
const tasks = new Map([
[
'frontend',
{
target: './assets/ComfyUI/app/frontend_management.py',
patch: './scripts/core-remove-frontend.patch',
},
],
[
'requirements',
{
Expand Down
Loading