Skip to content

Conversation

@robinjhuang
Copy link
Member

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 13, 2025
@socket-security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedclick@​8.2.0 ⏵ 8.1.895100100100100

View full report

@codecov
Copy link

codecov bot commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 44.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dosubot dosubot bot added the dependencies Pull requests that update a dependency file label May 13, 2025
"ruff",
"semver~=3.0.2",
"cookiecutter",
"click<=8.1.8"
Copy link

@polarathene polarathene May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming comments here are valid in this file:

Suggested change
"click<=8.1.8"
# Temporarily pin until `typer` is compatible:
# https://github.com/Comfy-Org/comfy-cli/issues/264#issuecomment-2871116559
"click<=8.1.8"

Better for maintainers to be aware that this isn't a direct dep required by comfy-cli, and that it can be removed at a later date.

Ref: #264 (comment)


You can rely on git blame I guess, but that's sometimes messy to navigate in my experience.

@robinjhuang robinjhuang merged commit 84bc824 into main May 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants