Skip to content

Fixed: Pin version of click dependency. #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robinjhuang merged 1 commit into from
May 13, 2025
Merged

Fixed: Pin version of click dependency. #265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ dependencies = [
"ruff",
"semver~=3.0.2",
"cookiecutter",
"click<=8.1.8"
Copy link

@polarathene polarathene May 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming comments here are valid in this file:

Suggested change
"click<=8.1.8"
# Temporarily pin until `typer` is compatible:
# https://github.com/Comfy-Org/comfy-cli/issues/264#issuecomment-2871116559
"click<=8.1.8"

Better for maintainers to be aware that this isn't a direct dep required by comfy-cli, and that it can be removed at a later date.

Ref: #264 (comment)

You can rely on git blame I guess, but that's sometimes messy to navigate in my experience.

]

[project.optional-dependencies]
Expand Down