-
Notifications
You must be signed in to change notification settings - Fork 101
Update pyproject specifications ver1 #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ject config for better resource accessibility
… specify dependency version requirement
…uires-comfyui version constraint for better understanding
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…tadata and compatibility information
|
Just FYI, once we added any new properties in pyproject specifications, we also need to update in core as well, see Comfy-Org/ComfyUI#8357 |
Co-authored-by: Robin Huang <[email protected]>
|
@snomiao Is this ready for review again? |
… comment for requires-comfyui for better readability and maintainability
…y-cli into sno-update-specifications
Hey @robinjhuang, sorry for late reply, it's ready for review again now :D |
* feat(config_parser.py): add comments for ComfyUI version compatibility and project classifiers to improve documentation and usability chore(config_parser.py): enhance project URLs by adding Documentation and Bug Tracker links for better project navigation * Update comfy_cli/registry/config_parser.py Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
|
@snomiao I guess we can close this PR since the PR that replaces it was merged 3 weeks ago? |
Respect latest specification.
see also - Update pyproject specifications ver2 #281 by snomiao · Pull Request #285 · Comfy-Org/comfy-cli
Will generate a pyproject.toml like this
Notion Context:
https://www.notion.so/drip-art/Use-compatibility-fields-conflict-resolution-UI-UX-2086d73d3650804e901fef5b511eb411
Note: comfy-cli is used by ComfyPR when creating new PRs