Skip to content

Conversation

@snomiao
Copy link
Member

@snomiao snomiao commented Jun 5, 2025

Respect latest specification.

see also - Update pyproject specifications ver2 #281 by snomiao · Pull Request #285 · Comfy-Org/comfy-cli

Will generate a pyproject.toml like this

[project]
name = "node"
description = ""
version = "1.0.0"
license = {file = "LICENSE"}
classifiers = [] 
# classifiers = [
#     # For OS-independent nodes (works on all operating systems)
#     "Operating System :: OS Independent",
# 
#     # OR for OS-specific nodes, specify the supported systems:
#     "Operating System :: Microsoft :: Windows",  # Windows specific
#     "Operating System :: POSIX :: Linux",  # Linux specific
#     "Operating System :: MacOS",  # macOS specific
#     
#     # GPU Accelerator support
#     "Environment :: GPU :: NVIDIA CUDA",    # NVIDIA CUDA support
#     "Environment :: GPU :: AMD ROCm",       # AMD ROCm support
#     "Environment :: GPU :: Intel Arc",      # Intel Arc support
#     "Environment :: NPU :: Huawei Ascend",  # Huawei Ascend support
#     "Environment :: GPU :: Apple Metal",    # Apple Metal support
# ]


[project.urls]
Repository = "https://github.com/Comfy-Org/comfy-custom-node"
#  Used by Comfy Registry https://registry.comfy.org
Documentation = "https://github.com/Comfy-Org/comfy-custom-node/wiki"
"Bug Tracker" = "https://github.com/Comfy-Org/comfy-custom-node/issues"

[tool.comfy]
PublisherId = ""
DisplayName = "comfy-custom-node"
Icon = ""
includes = []

# "requires-comfyui" = ">=1.0.0" # ComfyUI version compatibility

Notion Context:
https://www.notion.so/drip-art/Use-compatibility-fields-conflict-resolution-UI-UX-2086d73d3650804e901fef5b511eb411

Note: comfy-cli is used by ComfyPR when creating new PRs

snomiao added 3 commits June 5, 2025 05:23
…ject config for better resource accessibility
…uires-comfyui version constraint for better understanding
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 5, 2025
@codecov
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
unittests 45.49% <100.00%> (+0.97%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
comfy_cli/registry/config_parser.py 50.00% <100.00%> (+22.27%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dosubot dosubot bot added the dependencies Pull requests that update a dependency file label Jun 5, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jun 5, 2025
@jtydhr88
Copy link
Collaborator

jtydhr88 commented Jun 5, 2025

Just FYI, once we added any new properties in pyproject specifications, we also need to update in core as well, see Comfy-Org/ComfyUI#8357

@robinjhuang
Copy link
Member

@snomiao Is this ready for review again?

snomiao added 2 commits June 11, 2025 06:42
… comment for requires-comfyui for better readability and maintainability
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jun 13, 2025
@snomiao
Copy link
Member Author

snomiao commented Jun 13, 2025

@snomiao Is this ready for review again?

Hey @robinjhuang, sorry for late reply, it's ready for review again now :D

@snomiao snomiao requested a review from robinjhuang June 13, 2025 16:36
@snomiao snomiao self-assigned this Jun 13, 2025
@snomiao snomiao changed the title Update pyproject specifications Update pyproject specifications ver1 Jun 13, 2025
snomiao added a commit that referenced this pull request Jul 6, 2025
* feat(config_parser.py): add comments for ComfyUI version compatibility and project classifiers to improve documentation and usability
chore(config_parser.py): enhance project URLs by adding Documentation and Bug Tracker links for better project navigation

* Update comfy_cli/registry/config_parser.py

Co-authored-by: Copilot <[email protected]>

---------

Co-authored-by: Copilot <[email protected]>
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 26, 2025
@bigcat88
Copy link
Contributor

@snomiao I guess we can close this PR since the PR that replaces it was merged 3 weeks ago?

@bigcat88 bigcat88 added the question Further information is requested label Jul 27, 2025
@snomiao
Copy link
Member Author

snomiao commented Jul 28, 2025

@snomiao I guess we can close this PR since the PR that replaces it was merged 3 weeks ago?

@bigcat88 Sure! Thank you for reminder : D

@snomiao snomiao closed this Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file lgtm This PR has been approved by a maintainer question Further information is requested size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants