Skip to content

Conversation

@snomiao
Copy link
Member

@snomiao snomiao commented Jun 13, 2025

Same as Update pyproject specifications #281
Without empty classifiers placeholder:
classifiers = []

To ensure classifiers default as undefined in case authors don't want to fill it

Generated pyproject.toml:

[project]
name = "cli"
description = ""
version = "1.0.0"
license = {file = "LICENSE"} 
# classifiers = [
#     # For OS-independent nodes (works on all operating systems)
#     "Operating System :: OS Independent",
# 
#     # OR for OS-specific nodes, specify the supported systems:
#     "Operating System :: Microsoft :: Windows",  # Windows specific
#     "Operating System :: POSIX :: Linux",  # Linux specific
#     "Operating System :: MacOS",  # macOS specific
#     
#     # GPU Accelerator support. Pick the ones that are supported by your extension.
#     "Environment :: GPU :: NVIDIA CUDA",    # NVIDIA CUDA support
#     "Environment :: GPU :: AMD ROCm",       # AMD ROCm support
#     "Environment :: GPU :: Intel Arc",      # Intel Arc support
#     "Environment :: NPU :: Huawei Ascend",  # Huawei Ascend support
#     "Environment :: GPU :: Apple Metal",    # Apple Metal support
# ]


[project.urls]
Repository = "https://github.com/Comfy-Org/comfy-cli"
#  Used by Comfy Registry https://registry.comfy.org
Documentation = "https://github.com/Comfy-Org/comfy-cli/wiki"
"Bug Tracker" = "https://github.com/Comfy-Org/comfy-cli/issues"

[tool.comfy]
PublisherId = ""
DisplayName = "comfy-cli"
Icon = ""
includes = [] 
# "requires-comfyui" = ">=1.0.0"  # ComfyUI version compatibility

…y and project classifiers to improve documentation and usability

chore(config_parser.py): enhance project URLs by adding Documentation and Bug Tracker links for better project navigation
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jun 13, 2025
@codecov
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
comfy_cli/registry/config_parser.py 0.00% 4 Missing ⚠️
Flag Coverage Δ
unittests 48.07% <0.00%> (+2.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
comfy_cli/registry/config_parser.py 50.33% <0.00%> (-1.37%) ⬇️

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dosubot dosubot bot added the dependencies Pull requests that update a dependency file label Jun 13, 2025
@snomiao snomiao requested review from Copilot and robinjhuang June 25, 2025 12:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the pyproject specifications by removing the empty classifiers placeholder and adding commented hints to guide users on configuring version compatibility and OS/GPU support.

  • Adds a commented hint for ComfyUI version compatibility in the includes array.
  • Updates URL fields to include Documentation and Bug Tracker links.
  • Attaches a commented hint for classifiers under the license field to provide guidance on OS/GPU support.

@snomiao snomiao requested a review from christian-byrne June 26, 2025 10:55
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 5, 2025
@snomiao snomiao merged commit b9cc24f into main Jul 6, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants