-
Notifications
You must be signed in to change notification settings - Fork 101
feat: refactor env command to use ui.display_table for consistent table display #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Seems like a reasonable change. @bigcat88 Can you take a look? |
bigcat88
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the PR is good (tested locally), but some small changes need to be made.
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 12 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
thanks for the changes, can you remove the last unused import that |
|
sure, just removed it |
|
thanks for this contribution |
|
Nice cleanup and unification. Good job! 👍 |
|
thx guys🤗 |
What changed
Updated the
comfy envcommand to use our existingui.display_table()function instead of manually creating Rich Table objects.Why
Changes made
EnvChecker.fill_print_table()to return data tuples instead of creating a tableWorkspaceManager.fill_print_table()to return data tuples tooui.display_table()The output looks exactly the same to users.