Add frontend PR support for testing ComfyUI_frontend pull requests #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests - Add --frontend-pr option to launch command for temporary PR testing - Implement PR cache system with automatic expiration (7 days) and limits (10 PRs) - Add Node.js/npm verification and frontend build process with vite - Include pr-cache management commands (list, clean) - Cache built frontends for instant switching between PRs - Add comprehensive tests with 80% coverage for new modules - Update README with usage examples and cache management docs
dosubot
bot
added
size:XXL
Contributor
Author
|
These tests are failing |
christian-byrne
commented
Aug 9, 2025
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #309 +/- ##
==========================================
+ Coverage 47.91% 50.45% +2.54%
==========================================
Files 30 32 +2
Lines 3068 3381 +313
==========================================
+ Hits 1470 1706 +236
- Misses 1598 1675 +77
🚀 New features to boost your workflow:
|
dosubot
bot
added
size:XL
bigcat88
approved these changes
Aug 10, 2025
Contributor
bigcat88
left a comment
bigcat88
left a comment
There was a problem hiding this comment.
For testing, I checked out a PR from the community:
comfy launch --frontend-pr "#4641"
It was checked out successfully, and ComfyUI started nicely from it:
ComfyUI version: 0.3.48
[Prompt Server] web root: /home/shurik/.config/comfy-cli/pr-cache/frontend/Jackpkn-4641-fix_selection-overlay-performance/repo/dist
### Loading: ComfyUI-Manager (V3.35)
Without --frontend-pr, the original ComfyUI was started:
ComfyUI frontend version: 1.23.4
[Prompt Server] web root: /home/shurik/Comfy/comfy-cli-work/venv/lib/python3.12/site-packages/comfyui_frontend_package/static
### Loading: ComfyUI-Manager (V3.35)
After switching back to #4641, nothing was rebuilt, and the startup was very fast thanks to the cache.
The comfy pr-cache list command displays the cached version perfectly. I also tested the comfy pr-cache clean command, and it works as expected.
PR works just great.
Do I need to push a commit that will remove "# noqa: UP035" and "noqa: UP006" lines - with just replacing List with list and Dict with dict ?
…ture__ annotations - Remove unnecessary # noqa comments - Replace List[T] with list[T] and Dict[K,V] with dict[K,V] - Replace Optional[T] with T < /dev/null | None - Add 'from __future__ import annotations' to pr_cache.py - Remove unused typing imports
Contributor
Author
|
Thanks for the review and test.
Just fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to test frontend PRs directly from comfy-cli by automatically building and using frontend pull requests. This enables developers to quickly test frontend changes without manual setup, with intelligent caching for fast PR switching.
test-frontend-pr-comfy-cli.mp4