[feat] update frontend PR support for nx and pnpm #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
- Update verify_node_tools to automatically install pnpm when missing - Change build commands from npm to pnpm for modern frontend compatibility - Add user consent prompt before installing pnpm globally - Update unit tests to cover pnpm verification and auto-install scenarios - Maintain backward compatibility with existing function signatures Addresses frontend transition to nx/pnpm build system while ensuring robust user experience for QA, ops, and GTM teams.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #314 +/- ##
==========================================
+ Coverage 50.44% 50.63% +0.18%
==========================================
Files 32 32
Lines 3380 3405 +25
==========================================
+ Hits 1705 1724 +19
- Misses 1675 1681 +6
🚀 New features to boost your workflow:
|
christian-byrne
force-pushed
the
feat/update-frontend-pr-nx-pnpm
branch
from
02b6cc9 to
53306e8
Compare
bigcat88
reviewed
Sep 3, 2025
bigcat88
approved these changes
Sep 3, 2025
Contributor
bigcat88
left a comment
bigcat88
left a comment
There was a problem hiding this comment.
checked with pre-installed pnpm - everything works fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the frontend PR functionality (#309) to support the ComfyUI frontend's transition to nx and pnpm:
Background
The ComfyUI frontend has migrated to nx + pnpm and now strictly enforces pnpm usage via
only-allow pnpmpreinstall hook. The existing frontend PR feature (#309) fails on new frontend PRs because it tries to usenpm install.Changes Made
Core Logic (
comfy_cli/command/install.py):verify_node_tools()to check for pnpm and auto-install when missingnpm install→pnpm installTesting (
tests/comfy_cli/command/):User Experience
When pnpm exists: ✅ Proceeds normally
When pnpm missing: