Skip to content

Add slot compatibility checking for subgraph slots#1182

Merged
christian-byrne merged 1 commit intomasterfrom
fix/subgraph-slot-visual-feedback
Aug 1, 2025
Merged

Add slot compatibility checking for subgraph slots#1182
christian-byrne merged 1 commit intomasterfrom
fix/subgraph-slot-visual-feedback

Conversation

@benceruleanlu
Copy link
Member

@benceruleanlu benceruleanlu commented Jul 31, 2025

Add slot compatibility checking for subgraph slots.

Refuses connecting incompatible slots, and greys out accordingly when dragging.

Fixes: #1172
Fixes: #965

Screen.Recording.2025-08-01.033833.mp4

- Show 40% opacity for invalid drop targets when dragging connections
- Add isValidTarget() method to SubgraphInput/Output for drag validation
- Support visual feedback in nested subgraphs
- Consolidate slot drawing to include label rendering
- Add comprehensive tests for slot connections and visual feedback

🤖 Generated with Claude Code
Copy link
Contributor

@christian-byrne christian-byrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christian-byrne christian-byrne merged commit 6fa2e8e into master Aug 1, 2025
4 checks passed
@christian-byrne christian-byrne deleted the fix/subgraph-slot-visual-feedback branch August 1, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] SubgraphOutputNode slots retain connection type and color after disconnection [DevTask] Fix logic in NodeSlot.isValidTarget

2 participants