-
Notifications
You must be signed in to change notification settings - Fork 77
Run incremental component check earlier, save additional CI time #689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run incremental component check earlier, save additional CI time #689
Conversation
…, dotnet restore and msbuild setup. Since our incremental component checks use pwsh instead of msbuild, we can save an addition 4-6 minutes of CI time by skipping these steps.
…kips for dotnet sdk and machine configuration (pagefile, usermode dumps)
8c32163 to
fd2ad1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a case where the buildable components is empty?
It didn't get far enough to do the component check. The error is coming from git: Looking at 8c32163 and fd2ad1d, these commits are identical both in content and in the parent commit. The only discernable difference is that the latter is a commit that resides on our current In a normal push, the before commit is a direct ancestor of the after commit. However, with a force push, you're rewriting branch history. Since the before commit is often no longer part of the branch's history, and it has no direct relationship with the after commit and cannot be compared symmetrically. This is the error we're seeing here. The command Given that the command works locally, let's try updating the submodule to fetch the missing orphaned commit and see if that resolves the issue in CI. This also makes me wonder whether rebases are going to work as expected. I'll need to investigate before we can settle on a solution. |
4dbb8dd to
e9f0567
Compare
|
@michael-hawker It looks like that fixed the issue with force pushes! We should be able to merge once CI passes 😄 Note that we'll need to close off CommunityToolkit/Tooling-Windows-Submodule#290 first |
Updates build.yml to run incremental component check as early as possible-- before uno-check, dotnet restore, msbuild setup, sdk installation, and machine configuration (pagefile, usermode dumps).
Since our incremental component checks use pwsh instead of msbuild, we can save an addition 4-6 minutes of CI time per multitarget by skipping these dependency install steps.