-
Notifications
You must be signed in to change notification settings - Fork 77
Run incremental component check earlier, save additional CI time #689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Arlodotexe
merged 6 commits into
main
from
ci/incremental-builds/improvement/skip-uno-check
Jul 3, 2025
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3e41280
Updated build.yml to run incremental component check before uno-check…
Arlodotexe fd2ad1d
Move repository checkout to first build step, incremental build now s…
Arlodotexe 4797aa3
Check for HAS_BUILDABLE_COMPONENTS before installing .NET SDK
Arlodotexe 70b12f4
Update tooling submodule to include https://github.com/CommunityToolk…
Arlodotexe e9f0567
Add newline to end of file to test force-push
Arlodotexe 85cbd67
Update tooling to latest main
Arlodotexe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -76,15 +76,30 @@ jobs: | |
|
|
||
| # Steps represent a sequence of tasks that will be executed as part of the job | ||
| steps: | ||
| # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it | ||
| - name: Checkout Repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| submodules: recursive | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Get changed components | ||
| run: | | ||
| $changedComponents = $(./tooling/Get-Changed-Components.ps1 ${{ github.event.before }} ${{ github.event.after }}) | ||
| $buildableChangedComponents = $(./tooling/MultiTarget/Filter-Supported-Components.ps1 -Components $changedComponents -MultiTargets ${{ matrix.multitarget }} -WinUIMajorVersion ${{ matrix.winui }}) | ||
| echo "CHANGED_COMPONENTS_LIST=$(($buildableChangedComponents | ForEach-Object { "$_" }) -join ',')" >> $env:GITHUB_ENV | ||
| echo "HAS_BUILDABLE_COMPONENTS=$($buildableChangedComponents.Count -gt 0)" >> $env:GITHUB_ENV | ||
|
|
||
| - name: Configure Pagefile | ||
| if: ${{ env.ENABLE_DIAGNOSTICS == 'true' && env.HAS_BUILDABLE_COMPONENTS == 'true' }} | ||
| uses: al-cheb/[email protected] | ||
| with: | ||
| minimum-size: 32GB | ||
| maximum-size: 32GB | ||
| disk-root: "C:" | ||
|
|
||
| - name: Enable User-Mode Dumps collecting | ||
| if: ${{ env.ENABLE_DIAGNOSTICS == 'true' || env.COREHOST_TRACE != '' }} | ||
| if: ${{ (env.ENABLE_DIAGNOSTICS == 'true' || env.COREHOST_TRACE != '') && env.HAS_BUILDABLE_COMPONENTS == 'true' }} | ||
| shell: powershell | ||
| run: | | ||
| New-Item '${{ github.workspace }}\CrashDumps' -Type Directory | ||
|
|
@@ -93,6 +108,7 @@ jobs: | |
| Set-ItemProperty -Path 'HKLM:\SOFTWARE\Microsoft\Windows\Windows Error Reporting\LocalDumps' -Name 'DumpType' -Type DWord -Value '2' | ||
|
|
||
| - name: Install .NET SDK v${{ env.DOTNET_VERSION }} | ||
| if: ${{ env.ENABLE_DIAGNOSTICS == 'true' }} | ||
| uses: actions/setup-dotnet@v4 | ||
| with: | ||
| dotnet-version: ${{ env.DOTNET_VERSION }} | ||
|
|
@@ -101,19 +117,13 @@ jobs: | |
| if: ${{ env.ENABLE_DIAGNOSTICS == 'true' }} | ||
| run: dotnet --info | ||
|
|
||
| # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it | ||
| - name: Checkout Repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| submodules: recursive | ||
| fetch-depth: 0 | ||
|
|
||
| # Restore Tools from Manifest list in the Repository | ||
| - name: Restore dotnet tools | ||
| if: ${{ env.HAS_BUILDABLE_COMPONENTS == 'true' }} | ||
| run: dotnet tool restore | ||
|
|
||
| - name: Run Uno Check to Install Dependencies | ||
| if: ${{ matrix.multitarget != 'wasdk' && matrix.multitarget != 'linuxgtk' && matrix.multitarget != 'wpf' }} | ||
| if: ${{ matrix.multitarget != 'wasdk' && matrix.multitarget != 'linuxgtk' && matrix.multitarget != 'wpf' && env.HAS_BUILDABLE_COMPONENTS == 'true' }} | ||
| run: > | ||
| dotnet tool run uno-check | ||
| --ci | ||
|
|
@@ -127,15 +137,9 @@ jobs: | |
|
|
||
| - name: Add msbuild to PATH | ||
| uses: microsoft/setup-msbuild@v2 | ||
| if: ${{ env.HAS_BUILDABLE_COMPONENTS == 'true' }} | ||
| with: | ||
| vs-version: '[17.9,)' | ||
| # Get changed components | ||
| - name: Get changed components | ||
| run: | | ||
| $changedComponents = $(./tooling/Get-Changed-Components.ps1 ${{ github.event.before }} ${{ github.event.after }}) | ||
| $buildableChangedComponents = $(./tooling/MultiTarget/Filter-Supported-Components.ps1 -Components $changedComponents -MultiTargets ${{ matrix.multitarget }} -WinUIMajorVersion ${{ matrix.winui }}) | ||
| echo "CHANGED_COMPONENTS_LIST=$(($buildableChangedComponents | ForEach-Object { "$_" }) -join ',')" >> $env:GITHUB_ENV | ||
| echo "HAS_BUILDABLE_COMPONENTS=$($buildableChangedComponents.Count -gt 0)" >> $env:GITHUB_ENV | ||
|
|
||
| # Generate full solution with all projects (sample gallery heads, components, tests) | ||
| - name: Generate solution with ${{ matrix.multitarget }} gallery, components and tests | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.