Fix package name normalization to handle dots in addition to hyphens#25
Draft
Fix package name normalization to handle dots in addition to hyphens#25
Conversation
Co-authored-by: ccoulombe <22602168+ccoulombe@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix this issue.
Fix package name normalization to handle dots in addition to hyphens
Sep 23, 2025
jaraco_functools or jaraco.functools should both work and be valid names that returns results
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Package names with dots (e.g.,
jaraco.functools) were not being normalized correctly according to PEP 503, causing searches to fail when users tried both naming conventions. For example:The issue was that the package name canonicalization in
wild_requirements.pyonly replaced hyphens with underscores, but didn't handle dots, which should also be normalized to underscores per PEP 503.Solution
Updated the package name normalization logic to replace both dots and hyphens with underscores:
This ensures that all of these package name variations normalize to the same canonical form:
jaraco.functools→jaraco_functoolsjaraco-functools→jaraco_functoolsjaraco_functools→jaraco_functoolsTesting
test_package_name_normalization_dots_and_underscores()to verify the fixImpact
This change improves user experience by allowing both common package naming conventions to work correctly, while maintaining full backward compatibility. The fix follows Python packaging standards (PEP 503) and ensures consistent behavior across the tool.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.