Skip to content

Conversation

@luisina-santos
Copy link
Contributor

Since we want to containerize baton-tableau I'm trying to follow existent c1 pattern that parses the given url before create the connector and force a default api version to 3.19 to keep this behavior after update

https://github.com/ductone/c1/blob/main/pkg/connector/tableau/tableau.go#L29-L36

@coderabbitai
Copy link

coderabbitai bot commented Sep 25, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • cmd/baton-tableau/main.go is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch luisinasantos/match-c1-behavior

Comment @coderabbitai help to get the list of available commands and usage tips.

@luisina-santos luisina-santos merged commit c347272 into main Sep 26, 2025
4 checks passed
@luisina-santos luisina-santos deleted the luisinasantos/match-c1-behavior branch September 26, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants