Skip to content

update getConnector to follow existent c1 implementation #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luisina-santos merged 2 commits into from
Sep 26, 2025
Merged

update getConnector to follow existent c1 implementation #22

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95f0e45
update getConnector to follow existent c1 implementation
luisina-santos Sep 25, 2025
a5f87e8
use api version from flag and default to 3.19
luisina-santos Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions cmd/baton-tableau/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"fmt"
"net/url"
"os"
"strings"

"github.com/conductorone/baton-sdk/pkg/connectorbuilder"
"github.com/conductorone/baton-sdk/pkg/field"
Expand Down Expand Up @@ -48,12 +49,13 @@ func getConnector(ctx context.Context, tc *cfg.Tableau) (types.ConnectorServer,
return nil, err
}

apiVersion := tc.ApiVersion
if apiVersion == "" {
apiVersion = "3.17"
apiVersion := "3.19"
if tc.ApiVersion != "" {
apiVersion = tc.ApiVersion
}

serverPath := tc.ServerPath
serverPath = strings.TrimPrefix(serverPath, "https://")
serverPath = strings.TrimPrefix(serverPath, "http://")
baseUrl, err := url.JoinPath("https://", serverPath, "api", apiVersion)
if err != nil {
l.Error("error creating base url", zap.Error(err))
Expand Down