Skip to content

fix: speed on ReadN #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
raulb merged 6 commits into from
May 6, 2025
Merged

fix: speed on ReadN #279

raulb merged 6 commits into from
May 6, 2025

Conversation

@raulb
Copy link
Contributor

@raulb raulb commented Apr 30, 2025 •
edited
Loading

Description

Something on #276, more particularly on this diff, made my benchmarks slower.

i.e.:

Update

⚠️ This fixes the issue: 4abb909 ⚠️

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@raulb raulb force-pushed the fix-read-n-slowness branch from c144631 to 3331840 Compare April 30, 2025 18:08
@raulb raulb force-pushed the fix-read-n-slowness branch from 3b667fd to 4abb909 Compare April 30, 2025 23:18
@raulb raulb marked this pull request as ready for review April 30, 2025 23:20
@raulb raulb requested a review from a team as a code owner April 30, 2025 23:20
@raulb raulb self-assigned this Apr 30, 2025
@raulb raulb moved this from Triage to Ready for review in Conduit Main Apr 30, 2025
@raulb raulb mentioned this pull request May 5, 2025
Closed
@github-project-automation github-project-automation bot moved this from Ready for review to Reviewed (ready to ship) in Conduit Main May 6, 2025
@raulb raulb merged commit c2987ea into main May 6, 2025
3 checks passed
@raulb raulb deleted the fix-read-n-slowness branch May 6, 2025 09:59
@github-project-automation github-project-automation bot moved this from Reviewed (ready to ship) to Done in Conduit Main May 6, 2025
@raulb raulb mentioned this pull request May 6, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hariso hariso hariso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@raulb raulb

Labels

None yet

Projects

Conduit Main
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@raulb @hariso