Skip to content

feat(height, width): accept string #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(height, width): accept string #276

wants to merge 1 commit into from

Conversation

@rbalet
Copy link

@rbalet rbalet commented Jun 30, 2025 •
edited
Loading

Description

Closes: #272 (comment)

Note

User will be able to do imageHeight="200px" which is false.

As the exemple are clear enough, I wouldn't care, but if wished, I could add an additional

if(imageHeight && isNan(imageHeight) console.warn('imageHeight expect a number')

Or something similar

@Cordobo Cordobo self-assigned this Aug 2, 2025
@Cordobo Cordobo added this to the 20.0.1 milestone Aug 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Cordobo Cordobo

Labels

None yet

Projects

None yet

Milestone

20.0.1

Development

Successfully merging this pull request may close these issues.

feat(height, width): accept string

2 participants

@rbalet @Cordobo