Skip to content

feat(height, width): accept string #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(height, width): accept string #276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions projects/angularx-qrcode/src/lib/angularx-qrcode.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ export class QRCodeComponent implements OnChanges {
@Input()
public errorCorrectionLevel: QRCodeErrorCorrectionLevel = "M"
@Input() public imageSrc?: string
@Input() public imageHeight?: number
@Input() public imageWidth?: number
@Input() public imageHeight?: number | string
@Input() public imageWidth?: number | string
@Input() public margin = 4
@Input() public qrdata = ""
@Input() public scale = 4
Expand Down Expand Up @@ -195,8 +195,8 @@ export class QRCodeComponent implements OnChanges {
}

const centerImageSrc = this.imageSrc
const centerImageHeight = this.imageHeight || 40
const centerImageWidth = this.imageWidth || 40
const centerImageHeight = this.imageHeight ? +this.imageHeight : 40
const centerImageWidth = this.imageWidth ? +this.imageWidth : 40

switch (this.elementType) {
case "canvas": {
Expand Down