This repository was archived by the owner on Jan 17, 2026. It is now read-only.
Draft
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements simulation improvements for the camera and drive subsystems to better replicate real-world camera behavior in simulation by updating camera properties and drive ground truth tracking.
- Updated camera simulation properties (FPS, calibration error, latency metrics) in VisionIOPhotonVisionSim.
- Added simulation ground truth tracking via SwerveDriveOdometry in Drive.
- Updated Robot initialization to use simulation ground truth and switched the robot type to SIMBOT in Constants.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/main/java/org/curtinfrc/frc2025/subsystems/vision/VisionIOPhotonVisionSim.java | Updated camera properties for simulation with new FPS and added calibration and latency parameters. |
| src/main/java/org/curtinfrc/frc2025/subsystems/drive/Drive.java | Introduced simulation ground truth via SwerveDriveOdometry and integrated it with periodic updates and a dedicated getter. |
| src/main/java/org/curtinfrc/frc2025/Robot.java | Updated camera initialization to use simulation ground truth. |
| src/main/java/org/curtinfrc/frc2025/Constants.java | Changed the robot type to SIMBOT for simulation purposes. |
Comments suppressed due to low confidence (3)
src/main/java/org/curtinfrc/frc2025/subsystems/vision/VisionIOPhotonVisionSim.java:52
- The TODO comment suggests that the calibration error values may be placeholders. Consider adding a more descriptive comment or linking an issue that details the intended final calibration values.
cameraProperties.setCalibError(0.5, 0.5); // TODO
src/main/java/org/curtinfrc/frc2025/subsystems/vision/VisionIOPhotonVisionSim.java:53
- The average latency value is marked as TODO. Please ensure that a more definitive value or explanation is provided before merging into production.
cameraProperties.setAvgLatencyMs(15); // TODO
src/main/java/org/curtinfrc/frc2025/subsystems/vision/VisionIOPhotonVisionSim.java:54
- The latency standard deviation is also marked as a TODO. It is recommended to document the rationale or reference the source of these values to aid future maintenance.
cameraProperties.setLatencyStdDevMs(5); // TODO
Signed-off-by: Jade Turner <spacey-sooty@proton.me>
Signed-off-by: Jade Turner <spacey-sooty@proton.me>
2be067f to
02533f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: