Skip to content
This repository was archived by the owner on Jan 17, 2026. It is now read-only.

Conversation

@spacey-sooty
Copy link
Member

@spacey-sooty spacey-sooty commented May 29, 2025

TODO:

@spacey-sooty spacey-sooty linked an issue May 29, 2025 that may be closed by this pull request
@spacey-sooty spacey-sooty requested a review from Copilot June 4, 2025 09:43
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements simulation improvements for the camera and drive subsystems to better replicate real-world camera behavior in simulation by updating camera properties and drive ground truth tracking.

  • Updated camera simulation properties (FPS, calibration error, latency metrics) in VisionIOPhotonVisionSim.
  • Added simulation ground truth tracking via SwerveDriveOdometry in Drive.
  • Updated Robot initialization to use simulation ground truth and switched the robot type to SIMBOT in Constants.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/main/java/org/curtinfrc/frc2025/subsystems/vision/VisionIOPhotonVisionSim.java Updated camera properties for simulation with new FPS and added calibration and latency parameters.
src/main/java/org/curtinfrc/frc2025/subsystems/drive/Drive.java Introduced simulation ground truth via SwerveDriveOdometry and integrated it with periodic updates and a dedicated getter.
src/main/java/org/curtinfrc/frc2025/Robot.java Updated camera initialization to use simulation ground truth.
src/main/java/org/curtinfrc/frc2025/Constants.java Changed the robot type to SIMBOT for simulation purposes.
Comments suppressed due to low confidence (3)

src/main/java/org/curtinfrc/frc2025/subsystems/vision/VisionIOPhotonVisionSim.java:52

  • The TODO comment suggests that the calibration error values may be placeholders. Consider adding a more descriptive comment or linking an issue that details the intended final calibration values.
cameraProperties.setCalibError(0.5, 0.5); // TODO

src/main/java/org/curtinfrc/frc2025/subsystems/vision/VisionIOPhotonVisionSim.java:53

  • The average latency value is marked as TODO. Please ensure that a more definitive value or explanation is provided before merging into production.
cameraProperties.setAvgLatencyMs(15); // TODO

src/main/java/org/curtinfrc/frc2025/subsystems/vision/VisionIOPhotonVisionSim.java:54

  • The latency standard deviation is also marked as a TODO. It is recommended to document the rationale or reference the source of these values to aid future maintenance.
cameraProperties.setLatencyStdDevMs(5); // TODO

@spacey-sooty spacey-sooty force-pushed the jade/sim-camera-improvements branch from 2be067f to 02533f8 Compare June 22, 2025 02:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use real values for camera simulation

2 participants