Open
Conversation
|
Review app deployed to https://teaching-vacancies-review-pr-8434.test.teacherservices.cloud on AKS |
starswan
force-pushed
the
check-broken-links
branch
from
064ffd1 to
0f27988
Compare
starswan
force-pushed
the
check-broken-links
branch
from
d1dc3c8 to
9d3f5af
Compare
starswan
force-pushed
the
check-broken-links
branch
from
dec60bb to
7e16418
Compare
starswan
force-pushed
the
check-broken-links
branch
from
7e16418 to
ddbb1d3
Compare
scruti
reviewed
Jan 27, 2026
Comment on lines
35
to
44
| # POST_SECTIONS.each do |section, subcats| | ||
| # m.add posts_path(section), period: "weekly" | ||
| # subcats.each do |subcat, post| | ||
| # m.add subcategory_path(section, subcat), period: "weekly" | ||
| # | ||
| # post.each do |post| | ||
| # m.add post_path(section, subcat, post), period: "weekly" | ||
| # end | ||
| # end | ||
| # end |
Collaborator
There was a problem hiding this comment.
✂️ ?
Suggested change
| # POST_SECTIONS.each do |section, subcats| | |
| # m.add posts_path(section), period: "weekly" | |
| # subcats.each do |subcat, post| | |
| # m.add subcategory_path(section, subcat), period: "weekly" | |
| # | |
| # post.each do |post| | |
| # m.add post_path(section, subcat, post), period: "weekly" | |
| # end | |
| # end | |
| # end |
scruti
reviewed
Jan 27, 2026
check_broken_links.sh
Outdated
| | fgrep loc \ | ||
| | sed s'/ <loc>//' \ | ||
| | sed s'/<\/loc>//' \ | ||
| | wget -nv --spider -H -r -l1 -i - --user=$2 --password=$3 -P /tmp/spider \ |
Collaborator
There was a problem hiding this comment.
❓ From what I read, the --spider option makes wget visit but not download the pages. Wouldn't that make -P /tmp/spider redundant?
starswan
force-pushed
the
check-broken-links
branch
from
e7c4698 to
579e841
Compare
starswan
force-pushed
the
check-broken-links
branch
from
954d3b6 to
17d7559
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trello card URL
https://trello.com/c/Vt7GCpKO/2379-bring-broken-links-check-tool-from-get-into-teaching-service
Changes in this PR:
Check broken links