Improve the searchBar for other modules#388
Merged
ryuwd merged 1 commit intoDIRACGrid:mainfrom Aug 25, 2025
Merged
Conversation
f23810c to
09b792a
Compare
Contributor
|
@TheauW can you resolve the conflicts ? |
09b792a to
f3a6915
Compare
There was a problem hiding this comment.
Pull Request Overview
This pull request improves the SearchBar component by adding support for two new operators (NOT_LIKE and REGEX) and enhances the suggestion system to support current input-based suggestions. The changes also improve the API design by updating function signatures to use object parameters instead of positional parameters.
- Added support for
NOT_LIKEandREGEXoperators across different data type categories - Enhanced the suggestion system to optionally use current input for dynamic suggestion loading
- Refactored the
createSuggestionsfunction interface to use object parameters for better maintainability
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
packages/diracx-web-components/src/types/operators.ts |
Added new NOT_LIKE and REGEX operators and integrated them into existing operator categories |
packages/diracx-web-components/src/components/shared/SearchBar/SearchBar.tsx |
Enhanced SearchBar with current input detection, improved suggestion loading, and refactored API |
packages/diracx-web-components/src/components/shared/SearchBar/SearchField.tsx |
Updated SearchField to support suggestions loading state and removed unused parameters |
packages/diracx-web-components/src/components/shared/SearchBar/Utils.tsx |
Fixed number validation logic and updated function signatures to use object parameters |
packages/diracx-web-components/src/types/SearchBarToken.ts |
Removed deprecated hideSuggestion property from token type |
packages/diracx-web-components/src/types/SearchBarSuggestions.ts |
Removed deprecated hideSuggestion property from suggestions type |
packages/diracx-web-components/src/components/JobMonitor/JobSearchBar.tsx |
Updated to use new object-based parameter structure and improved suggestion logic |
| Other files | Updated tests and stories to reflect API changes, improved test reliability |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/diracx-web-components/src/components/shared/SearchBar/Utils.tsx
Outdated
Show resolved
Hide resolved
packages/diracx-web-components/src/components/shared/SearchBar/SearchBar.tsx
Outdated
Show resolved
Hide resolved
packages/diracx-web-components/src/components/shared/SearchBar/SearchBar.tsx
Show resolved
Hide resolved
packages/diracx-web-components/src/components/JobMonitor/JobSearchBar.tsx
Show resolved
Hide resolved
12bbe65 to
a567845
Compare
aldbr
reviewed
Aug 25, 2025
packages/diracx-web-components/src/components/shared/SearchBar/SearchField.tsx
Outdated
Show resolved
Hide resolved
a567845 to
eed3ade
Compare
aldbr
approved these changes
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📍Needs: DIRACGrid/diracx#605
I improved the
SearchBarto support the two new operators.I also added the ability to use the current input, so developers can access it in the suggestion function. If the current input is used, the suggestions will be reloaded for every new letter typed.
cc @ryuwd