Skip to content

Improve the searchBar for other modules#388

Merged
ryuwd merged 1 commit intoDIRACGrid:mainfrom
TheauW:twartel-improve-searchbar
Aug 25, 2025
Merged

Improve the searchBar for other modules#388
ryuwd merged 1 commit intoDIRACGrid:mainfrom
TheauW:twartel-improve-searchbar

Conversation

@TheauW
Copy link
Contributor

@TheauW TheauW commented Jul 23, 2025

📍Needs: DIRACGrid/diracx#605

I improved the SearchBar to support the two new operators.
I also added the ability to use the current input, so developers can access it in the suggestion function. If the current input is used, the suggestions will be reloaded for every new letter typed.

cc @ryuwd

@TheauW TheauW force-pushed the twartel-improve-searchbar branch 2 times, most recently from f23810c to 09b792a Compare August 13, 2025 15:06
@ryuwd
Copy link
Contributor

ryuwd commented Aug 20, 2025

@TheauW can you resolve the conflicts ?

@TheauW TheauW force-pushed the twartel-improve-searchbar branch from 09b792a to f3a6915 Compare August 21, 2025 08:14
@ryuwd ryuwd requested a review from Copilot August 21, 2025 18:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request improves the SearchBar component by adding support for two new operators (NOT_LIKE and REGEX) and enhances the suggestion system to support current input-based suggestions. The changes also improve the API design by updating function signatures to use object parameters instead of positional parameters.

  • Added support for NOT_LIKE and REGEX operators across different data type categories
  • Enhanced the suggestion system to optionally use current input for dynamic suggestion loading
  • Refactored the createSuggestions function interface to use object parameters for better maintainability

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
packages/diracx-web-components/src/types/operators.ts Added new NOT_LIKE and REGEX operators and integrated them into existing operator categories
packages/diracx-web-components/src/components/shared/SearchBar/SearchBar.tsx Enhanced SearchBar with current input detection, improved suggestion loading, and refactored API
packages/diracx-web-components/src/components/shared/SearchBar/SearchField.tsx Updated SearchField to support suggestions loading state and removed unused parameters
packages/diracx-web-components/src/components/shared/SearchBar/Utils.tsx Fixed number validation logic and updated function signatures to use object parameters
packages/diracx-web-components/src/types/SearchBarToken.ts Removed deprecated hideSuggestion property from token type
packages/diracx-web-components/src/types/SearchBarSuggestions.ts Removed deprecated hideSuggestion property from suggestions type
packages/diracx-web-components/src/components/JobMonitor/JobSearchBar.tsx Updated to use new object-based parameter structure and improved suggestion logic
Other files Updated tests and stories to reflect API changes, improved test reliability

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@TheauW TheauW force-pushed the twartel-improve-searchbar branch from 12bbe65 to a567845 Compare August 25, 2025 07:39
@TheauW TheauW force-pushed the twartel-improve-searchbar branch from a567845 to eed3ade Compare August 25, 2025 12:27
@ryuwd ryuwd merged commit f6fb4e9 into DIRACGrid:main Aug 25, 2025
14 checks passed
@TheauW TheauW deleted the twartel-improve-searchbar branch August 25, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants