fix: Remove trial_id check when loading Optuna study#499
Open
rclarsfull wants to merge 2 commits intoDLR-RM:masterfrom
Open
fix: Remove trial_id check when loading Optuna study#499rclarsfull wants to merge 2 commits intoDLR-RM:masterfrom
rclarsfull wants to merge 2 commits intoDLR-RM:masterfrom
Conversation
If no trail id ist given to load _trail() it, will load the best trail. When checking `trai_id != None` this disables this feature and makes it unusabel.
araffin
reviewed
Aug 29, 2025
|
|
||
|
|
||
| See https://github.com/DLR-RM/rl-baselines3-zoo/blob/master/CHANGELOG.md | ||
|
|
araffin
reviewed
Aug 30, 2025
| raise ValueError(f"Hyperparameters not found for {self.algo}-{self.env_name.gym_id} in {self.config}") | ||
|
|
||
| if self.storage and self.study_name and self.trial_id: | ||
| if self.storage and self.study_name: |
Member
There was a problem hiding this comment.
I think this check is needed (see failures on CI), instead we could allow passing a special value like -1 to allow loading the best trial
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If no trail id ist given to load _trail() it, will load the best trail. When checking
trai_id != Nonethis disables this feature and makes it unusabel.Motivation and Context
I just deletet the check, so its possile to just do this to train with the best taril.
Issue: #498
closes #498
Types of changes
Checklist:
make format(required)make check-codestyleandmake lint(required)make pytestandmake typeboth pass. (required)Note: we are using a maximum length of 127 characters per line