Skip to content

fix: Remove trial_id check when loading Optuna study #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rclarsfull wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Remove trial_id check when loading Optuna study #499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57ccd4c
fix: Remove trial_id check when loading Optuna study
rclarsfull Aug 28, 2025
390e25a
chore: add changelog entry
rclarsfull Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions docs/misc/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,11 @@ Changelog


See https://github.com/DLR-RM/rl-baselines3-zoo/blob/master/CHANGELOG.md

Copy link
Member

@araffin araffin Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see line just above

Bug Fixes:
^^^^^^^^^^
- Remove trial_id check when loading Optuna study (@rclarsfull)

Contributors:
-------------
- @rclarsfull
2 changes: 1 addition & 1 deletion rl_zoo3/exp_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ def read_hyperparameters(self) -> tuple[dict[str, Any], dict[str, Any]]:
else:
raise ValueError(f"Hyperparameters not found for {self.algo}-{self.env_name.gym_id} in {self.config}")

if self.storage and self.study_name and self.trial_id:
if self.storage and self.study_name:
Copy link
Member

@araffin araffin Aug 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this check is needed (see failures on CI), instead we could allow passing a special value like -1 to allow loading the best trial

print("Loading from Optuna study...")
study_hyperparams = self.load_trial(self.storage, self.study_name, self.trial_id)
hyperparams.update(study_hyperparams)
Expand Down
Loading