Fix forgotten merge

[vmcj]

No description provided.

[tom93]

There are a couple of places that still mention lib/vendor, do they need updating?

Makefile:292:  -rm -rf lib/vendor/*
.github/jobs/data/codespellignorefiles.txt:13:./lib/vendor
.github/jobs/syntax-check:26:       -path ./lib/vendor        -prune \
.github/jobs/syntax-check:44:          echo "$i" | grep -qvE ...

Edit: Oops, I missed .github/jobs/syntax-check:51. I'll fix it in #2635.

[tom93]

Earlier commits introduced an issue, make maintainer-install doesn't actually run composer-dump-autoload-dev. I committed a fix and some other cleanup in branch 'fix_forgotten_merge_suggestions' of my fork (commits).

[vmcj]

Earlier commits introduced an issue, make maintainer-install doesn't actually run composer-dump-autoload-dev. I committed a fix and some other cleanup in branch 'fix_forgotten_merge_suggestions' of my fork (commits).

I'll cherry-pick (& alter) some of those.

[tom93]

@vmcj, what do you think about a0fd9fd? (That's the simplified relative paths -- ../webapp/vendor becomes vendor). Should I create a separate PR, or just drop it?

[vmcj]

@vmcj, what do you think about a0fd9fd? (That's the simplified relative paths -- ../webapp/vendor becomes vendor). Should I create a separate PR, or just drop it?

I liked both of the commits but wanted to close this PR first.

So bugfix before refactoring.

[tom93]

I liked both of the commits but wanted to close this PR first.

I created a separate PR (#2635).