Merge webapp/vendor/Makefile into webapp/Makefile #2636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I find it easier to follow when all the composer commands are in the same Makefile. Also move `composer auto-scripts` back into inplace-install-l, out of concern for ordering issues. It was moved into a prereq of inplace-install in commit ab267ec (Put lib/vendor close to the webapp, 2024-06-23).
Just moving around the lines, no functional changes.
Merged
|
I think this is personal preference as I find this harder to follow as I already stated in the other PR. Let's see what the rest thinks. |
vmcj
reviewed
Jul 30, 2024
| # the autoload file. | ||
| # We skip it if autoload_runtime.php already exists, to avoid running composer | ||
| # as root during `sudo make install-domserver`. | ||
| composer-dump-autoload: vendor/autoload_runtime.php |
There was a problem hiding this comment.
I'm not sure if we need composer-dump-autoload again. The whole reason I started with the move was to get less phony targets so if possible I rather get rid of that one.
There was a problem hiding this comment.
I added it back for symmetry with composer-dump-autoload-dev, like composer-dependencies(-dev). But it's just a naming choice, happy to change it back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued from #2618 (comment).