Fix updates when no contest is set #2621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: webapp/src/Service/DOMJudgeService.php
Did you find this useful? React with a 👍 or 👎 |
| ->andWhere('b.done = 0'); | ||
|
|
||
| if (!(bool)$this->config->get('show_balloons_postfreeze')) { | ||
| $balloonsQuery->andWhere('s.submittime < co.freezetime'); |
There was a problem hiding this comment.
If there is no freeze, what does this do?
There was a problem hiding this comment.
That's a good question. I would say we wouldn't handout balloons at all. I'll check for that (or just use the old code again).
This fixes: https://domjudge.sentry.io/issues/5634564396/?project=6376669&query=is%3Aunresolved+issue.priority%3A%5Bhigh%2C+medium%5D&referrer=issue-stream&statsPeriod=14d&stream_index=1 On the main balloonpage we don't display those balloons so it makes sense to also not update the counter in the menu.
vmcj
force-pushed
the
symfony_error_no_contest
branch
from
de6bb42 to
a094543
Compare
nickygerritsen
approved these changes
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this method of solving is actually wrong as we normally have another behaviour.
I can see the usecase for having 2 contests like the PacNW situation with divisions where you would still want to hand out balloons to both contests so I think we should refactor to also have the same behavior here (when selectedContest=-1 -> display everything from all active contests).