Verify that timestrings can be parsed #3051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickygerritsen
approved these changes
Aug 6, 2025
vmcj
force-pushed
the
unknown_timezone_starttime
branch
from
0d6e799 to
1c2cb4f
Compare
meisterT
reviewed
Aug 6, 2025
webapp/src/Entity/Contest.php
Outdated
| if (preg_match("/^[+-]?\d+:\d\d(:\d\d(\.\d{1,6})?)?$/", $timeString) !== 1) { | ||
| try { | ||
| $date = new DateTime($timeString); | ||
| } catch (Exception) { |
There was a problem hiding this comment.
does the exception here tell us what's wrong? If so, can we extract it (or get it from somewhere else) and return it to the user?
There was a problem hiding this comment.
Ugly message but more info yes.
vmcj
force-pushed
the
unknown_timezone_starttime
branch
from
8130426 to
7c0f515
Compare
meisterT
reviewed
Aug 6, 2025
vmcj
force-pushed
the
unknown_timezone_starttime
branch
from
47b7786 to
f2110f0
Compare
In case of "unknown" timezones we would silently set the starttime to 0 but leave the startTimeString so the user would not be aware that the starttime is set to a completely different value.
vmcj
force-pushed
the
unknown_timezone_starttime
branch
from
f2110f0 to
b90a235
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of "unknown" timezones we would silently set the starttime to 0 but leave the startTimeString so the user would not be aware that the starttime is set to a completely different value.