Allow the judgehost role to access submissions past end of contest vi… #3082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a the API. This is already possible by requesting a specific submissions; this will make it more consistent. (cherry picked from commit a24340f)
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
vmcj
reviewed
Sep 7, 2025
Comment on lines
+458
to
+459
| if (!$request->attributes->has('id') && !$request->query->has('ids') && | ||
| !($this->dj->checkrole('admin') || $this->dj->checkrole('judgehost'))) { |
There was a problem hiding this comment.
I think the ! can be extracted further which makes it easier to read. And maybe admin should get the judgehost role implicit?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…a the API.
This is already possible by requesting a specific submissions; this will make it more consistent.
(cherry picked from commit a24340f)