Skip to content

Allow the judgehost role to access submissions past end of contest vi… #3082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2025
Merged

Allow the judgehost role to access submissions past end of contest vi… #3082

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion webapp/src/Controller/API/SubmissionController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,8 @@ protected function getQueryBuilder(Request $request): QueryBuilder

// If an ID has not been given directly, only show submissions before contest end.
// This allows us to use eventlog on too-late submissions while not exposing them in the API directly.
if (!$request->attributes->has('id') && !$request->query->has('ids') && !$this->dj->checkrole('admin')) {
if (!$request->attributes->has('id') && !$request->query->has('ids') &&
!($this->dj->checkrole('admin') || $this->dj->checkrole('judgehost'))) {
Comment on lines +458 to +459
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the ! can be extracted further which makes it easier to read. And maybe admin should get the judgehost role implicit?

$queryBuilder->andWhere('s.submittime < c.endtime');
}

Expand Down
Loading