Restrict clarifications to teams in the contest #3114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmcj
force-pushed
the
limited_clar_teams
branch
from
9f6fbe3 to
f7261e7
Compare
Kevinjil
approved these changes
Sep 23, 2025
vmcj
commented
Sep 24, 2025
meisterT
approved these changes
Sep 24, 2025
When you have shared DOMjudge instance with 2 different contests with teams limited by categories (or directly assigned) we would still show all known teams (even teams not in that contest). We now let the DOMjudge service handle this.
vmcj
force-pushed
the
limited_clar_teams
branch
from
14e6966 to
063106a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is helpful for when:
You have a shared DOMjudge instance with 2 different contests
The contests are not open to all teams but limited by categories (or directly assigned).
When you're a jury member in one of the contests you would still see all teams (union of both contests) in the
send clarificationpage.I do wonder if this is duplicated somewhere, and if we shouldn't let a dedicated Service handle the teams. The other reasonable place is the Contest itself but as that's an Entity it doesn't have an easy way of exposing which teams are in the contest when the contest is open to all teams (as you would need to query the database).
If there would be a TeamService we can change all queries to there and make sure we always get the consistent set without having to do this logic everywhere. For example I first tried this with the
Contest->getTeams()which would return nothing in normal cases (but I would say is reasonable without this background knowledge).