Fix ssr error by only importing altcha on the client side#4161
Merged
kshepherd merged 1 commit intoDSpace:mainfrom Apr 10, 2025
Merged
Fix ssr error by only importing altcha on the client side#4161kshepherd merged 1 commit intoDSpace:mainfrom
kshepherd merged 1 commit intoDSpace:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
The issue was caused by the fact that altcha was loaded server side, and that's not supported. When it tries to define the
altcha-widgetthe server-side throws an exception.I fixed it by removing the import everywhere, and putting it in
browser-app.config.tsI also removed an unnecessary ngVar, as they can be bad for performance.
Instructions for Reviewers
Ensure that the ssr error is gone, and that the altcha captchas still work.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.