Skip to content

fix: ensure unique IDs for dynamic list items#4331

Open
pcg-kk wants to merge 1 commit intoDSpace:mainfrom
pcg-kk:4330/radio-buttons-has-correct-names
Open

fix: ensure unique IDs for dynamic list items#4331
pcg-kk wants to merge 1 commit intoDSpace:mainfrom
pcg-kk:4330/radio-buttons-has-correct-names

Conversation

@pcg-kk
Copy link
Contributor

@pcg-kk pcg-kk commented May 13, 2025

References

Add references/links to any related issues or PRs. These may include:

Description

After this fix selection in each ds-dynamic-form-array is working separetly.

Instructions for Reviewers

  1. Select something from radio button in ds-dynamic-form-array
  2. Duplicate row
  3. Try to select something from first or last radio button.

List of changes in this PR:

  • id of radio buttons, and for value for the labals

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@pcg-kk pcg-kk force-pushed the 4330/radio-buttons-has-correct-names branch from b730e20 to e77f78f Compare February 12, 2026 12:13
@alegontarz
Copy link

Could you please add detailed testing steps and specify which submission form contains the repeatable radio buttons?
At the moment, it’s unclear where this scenario can be reproduced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug component: submission

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

Radio buttons in duplication list doesn't work correctly

3 participants