Skip to content

Backport 2774 to dspace 9 x#4485

Open
marsaoua wants to merge 3 commits intoDSpace:dspace-9_xfrom
tuub:backport-2774-to-dspace-9_x
Open

Backport 2774 to dspace 9 x#4485
marsaoua wants to merge 3 commits intoDSpace:dspace-9_xfrom
tuub:backport-2774-to-dspace-9_x

Conversation

@marsaoua
Copy link

This Pull-Request is a backport of #2774 to the dspace-9_x version

Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marsaoua : Thanks for this backport. Just a few notes below though that it appears that the translations in this PR are different from those on the main branch (and in #2774). Is this purposeful or accidental?

Obviously it may be best to ensure we have identical translations in both branches.


// "cookies.consent.ok": "That's ok",
"cookies.consent.ok": "Das ist in Ordnung.",
"cookies.consent.ok": "Zustimmen",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marsaoua : I'm a bit confused because this change didn't occur in #2774. So, this means 9.x has a different translation that the main branch.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tdonohue something is defenetly wrong, 9.x has a different translation that the main branch. I did not think to much and just cherry-picked the 3 commits from #2774. But it seems that only this commit 027a5ec was merged.

"cookies.consent.content-modal.services": "Dienste",

// "cookies.consent.content-modal.service": "service",
"cookies.consent.content-modal.service": "Dienst",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These last two translations are also different in #2774. In that PR and on main, these are translated as Dienstleistungen and Dienstleistung. So, this is another example of a place where the translations look to be different.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not find these lines on the main nor on 9.x branch. Those 2 lines are from #2774 commit 4ca1edf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants