Skip to content

Conversation

bky373
Copy link
Contributor

@bky373 bky373 commented Aug 20, 2024

배경

  • label 추가 단계에서 403 Forbidden 오류 발생
    image
  • job 이 실패하였음에도 catch 블록으로 인해 오류를 인지하지 못하는 문제 발생

작업

  • contents 및 pull-requests 에 대해 write 권한을 부여하여 label 을 추가할 수 있도록 함
  • catch 블록을 제거하여 단계가 실패하였음을 인지할 수 있도록 함

Comment on lines 6 to 8
permissions:
contents: write
pull-requests: write
Copy link
Member

@DaleSeo DaleSeo Aug 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

최소 권한 원칙을 따라 이 부분은 label-lang 작업 아래로 이동시키는 게 좋을 것 같습니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 좋은 의견 감사합니다! 옮겨두었고, 바로 병합하겠습니다!

@bky373 bky373 merged commit 81d4e12 into DaleStudy:main Aug 22, 2024
2 checks passed
@bky373 bky373 deleted the pr-lang-labeler branch August 23, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants