Skip to content

ci: add permissions for pr labels #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 22, 2024
Merged

ci: add permissions for pr labels #354

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3859b6
ci: add permissions on contents and pull-requests
bky373 Aug 20, 2024
34a8f36
ci: remove catch block to recognize failure
bky373 Aug 20, 2024
9d47d88
ci: apply review
bky373 Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/integration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ name: 🔄 Integration
on:
pull_request:

permissions:
contents: write
pull-requests: write
Copy link
Member

@DaleSeo DaleSeo Aug 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

최소 권한 원칙을 따라 이 부분은 label-lang 작업 아래로 이동시키는 게 좋을 것 같습니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 좋은 의견 감사합니다! 옮겨두었고, 바로 병합하겠습니다!


jobs:
linelint:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -81,5 +85,5 @@ jobs:
}
}

run().catch(err => console.error(err));
run();
"