Conversation
dependencies: use Hilt instead of koin for better performance use Ktor, Ktorfit, CIO instead of OkHttp and Retorfit for overall async network use DataStore, EncryptedDataStore instead of SharedPreference for async preference load and store use Version Catalog, kts script, java 17 remove PermissionX, AboutPage style: Single Activity architect. Jetpack Compose Navigation for routing.
|
Thanks for your wonderful work! This is a huge PR, and I need more time to review it during holiday. |
…nterface to manage user preference
STYLE-PRACTICES.md
Outdated
| ### **要**针对不同账户系统使用不同的数据类型。 | ||
|
|
||
| 旦夕是面向多类型账户系统的，不应想当然地把 `PersonInfo` 视作只包含 UIS 账号密码的数据类型，也不要在设置中过多出现「复旦」有关的字样。 | ||
| 旦夕是面向多类型账户系统的，`PersonInfo` 是只针对 UIS 账号密码的数据类型。 |
There was a problem hiding this comment.
Is this sentence contradicting itself? Why does PersonInfo only contain Fudan's UIS information if we are aiming at a general-use account? Are there other PersonInfo-like data classes in the future? Clarify it.
There was a problem hiding this comment.
There should not be any general-use account. UIS account UISInfo and FDUHole account OTJWTToken should be kept separate since they can be logged in and logged out independently. Also, any data class like PersonInfo, which I guess means detailed info of an account, should load from network every time app open. Only those info binding to an account token or credential, like id, name, can be stored in persistent storage.
I will update this sentence.
| android:exported="false"/> | ||
| <activity | ||
| android:name=".SingleFragmentActivity" | ||
| android:exported="false" /> <!-- Opt-out the usage statistics collection by Google. --> |
There was a problem hiding this comment.
Keep this comment about android.webkit.WebView.MetricsOptOut.
There was a problem hiding this comment.
finished, may some bug of GitHub
| /** | ||
| * @return a list whose size is 6. | ||
| * The sequence is 文科馆、理科馆、医科馆1-6层、张江馆、江湾馆、医科馆B1 | ||
| */ |
There was a problem hiding this comment.
Keep this comment for future reference.
| if (showPermissionDialog) { | ||
| RequestSinglePermissionDialog( | ||
| permission = Manifest.permission.ACCESS_COARSE_LOCATION, | ||
| rationale = "我们向您请求大致位置权限，是因为当前页面正在调用 Geolocation API 来获知您的大致位置。", |
|
I cannot log in UIS; it shows "Channel was closed".
Edit: the problem is on my side. I am using a custom DNS resolver (Adguard) and it resolves the server address to an IPv6 address, which is unsupported in our LAN. |
多试几次呢 |
多试几次也没用，是瞬间失败，没有过程。网络流量里看到有连接过 <uis.fudan.edu.cn>。 |
2 participants
No description provided.