-
Notifications
You must be signed in to change notification settings - Fork 3
Migrate to Jetpack Compose #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JingYiJun
wants to merge
15
commits into
DanXi-Dev:main
Choose a base branch
from
JingYiJun:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
399b015
refactor: migrate to Jetpack Compose
JingYiJun 69e94f5
chore: git remove output-metadata.json
JingYiJun 230045a
docs: update STYLE-PRACTICES.md
JingYiJun de10141
docs: update README.md
JingYiJun 3ffe483
feat: dynamic language setting use AppCompat API, add DataStoreItem I…
JingYiJun 7a2601f
feat: remove PersonInfo, add haptics when pull to refresh
JingYiJun 035e0de
doc: explain for account system
JingYiJun 1988193
feat: add i18n for location permission rationale. restore comments fo…
JingYiJun a16691b
refactor: change package name to com.fduhole.danxi
JingYiJun d4fd9f3
chore: update theme to new app name
JingYiJun 5af1f9b
style: unify scroll state naming
JingYiJun 96824d5
fix: fudan state holder not found
JingYiJun ed354f9
feat: use current page state instead of Pager
JingYiJun 1626536
fix: login uis message not match
JingYiJun e673960
fix: current page index error
JingYiJun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,6 +3,7 @@ | |
| *.aar | ||
| *.ap_ | ||
| *.aab | ||
| output-metadata.json | ||
|
|
||
| # Files for the ART/Dalvik VM | ||
| *.dex | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this sentence contradicting itself? Why does
PersonInfoonly contain Fudan's UIS information if we are aiming at a general-use account? Are there otherPersonInfo-like data classes in the future? Clarify it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should not be any general-use account. UIS account
UISInfoand FDUHole accountOTJWTTokenshould be kept separate since they can be logged in and logged out independently. Also, any data class likePersonInfo, which I guess means detailed info of an account, should load from network every time app open. Only those info binding to an account token or credential, likeid,name, can be stored in persistent storage.I will update this sentence.