[stable/redis-ha] fix: replace deprecated gitversion with version#339
Closed
kvanzuijlen wants to merge 4 commits intoDandyDeveloper:masterfrom
Closed
[stable/redis-ha] fix: replace deprecated gitversion with version#339kvanzuijlen wants to merge 4 commits intoDandyDeveloper:masterfrom
kvanzuijlen wants to merge 4 commits intoDandyDeveloper:masterfrom
Conversation
Owner
|
@kvanzuijlen Isn't |
Contributor
Author
I didn't know that, but indeed, after reading the docs, it is. Do you want me to change it to |
Owner
|
@kvanzuijlen Yes please! If you can merge in master to fix the conflicts as well. Thank you! |
Contributor
Author
|
@DandyDeveloper done! |
DandyDeveloper
previously approved these changes
Sep 12, 2025
Owner
|
@kvanzuijlen Can you rebase and recommit? Hopefully the tests will pass now. |
9967721 to
6832ed2
Compare
Contributor
Author
|
@DandyDeveloper I messed up the rebase, will close and reopen a new PR! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Capabilities.KubeVersion.GitVersionwas deprecated with the release of Helm v3.Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname])