Conversation
https://github.com/Dargon789/foundry/blob/94f4892dcef8fea1a98b9fc4ac98cf8818a38a03/.devcontainer/devcontainer.json Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe pull request updates the development container configuration in .devcontainer/devcontainer.json; reviewers should focus on how the container image, extensions, settings, and workspace mounting behavior have changed and ensure they still match the project’s development needs. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Summary of ChangesHello @Dargon789, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the development container configuration, moving from a Hardhat and Node.js-centric environment to one tailored for Rust and Foundry development. The changes involve adopting a custom Dockerfile, integrating Rust-specific VS Code extensions and settings, enhancing the shell experience with Zsh, and optimizing Rust build times through cargo cache mounts. This update aims to provide a more robust and efficient development setup for projects utilizing the Foundry framework. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request overhauls the devcontainer configuration, transitioning from a Hardhat/Node.js environment to a Foundry/Rust setup. The new configuration is well-structured, leveraging a custom Dockerfile and caching Cargo dependencies for better performance. I've added a couple of suggestions to improve the maintainability and robustness of the devcontainer.json file. Specifically, I've pointed out a potential issue with enabling all Cargo features for rust-analyzer and suggested a way to make the volume mount paths more dynamic.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Dargon789 <64915515+Dargon789@users.noreply.github.com>
Dargon789/foundry@48533bb
Summary by Sourcery
Chores: