Skip to content

Conversation

@lisaah
Copy link
Contributor

@lisaah lisaah commented Dec 10, 2025

Motivation

Adds the flagEvaluationEndpointBuilder that was previously added to the configuration interface for accurate typing.

Changes

This is a type only change.

Test instructions

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

@lisaah lisaah requested a review from a team as a code owner December 10, 2025 18:55
@lisaah lisaah changed the title Add flagEvaluationEndpointBuilder to TransportConfiguration interface. 🎨 Add flagEvaluationEndpointBuilder to TransportConfiguration interface. Dec 10, 2025
@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Dec 10, 2025

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 164.30 KiB 164.30 KiB 0 B 0.00%
Rum Profiler 5.21 KiB 5.21 KiB 0 B 0.00%
Rum Recorder 19.74 KiB 19.74 KiB 0 B 0.00%
Logs 56.14 KiB 56.14 KiB 0 B 0.00%
Flagging 944 B 944 B 0 B 0.00%
Rum Slim 121.57 KiB 121.57 KiB 0 B 0.00%
Worker 23.63 KiB 23.63 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base CPU Time (ms) Local CPU Time (ms) 𝚫%
RUM - add global context 0.0058 0.0067 +15.52%
RUM - add action 0.0175 0.0197 +12.57%
RUM - add error 0.0159 0.0191 +20.13%
RUM - add timing 0.0045 0.0046 +2.22%
RUM - start view 0.005 0.0041 -18.00%
RUM - start/stop session replay recording 0.0012 0.0007 -41.67%
Logs - log message 0.0218 0.0167 -23.39%
🧠 Memory Performance
Action Name Base Memory Consumption Local Memory Consumption 𝚫
RUM - add global context 25.94 KiB 25.55 KiB -402 B
RUM - add action 49.52 KiB 47.43 KiB -2.10 KiB
RUM - add timing 24.32 KiB 24.95 KiB +653 B
RUM - add error 54.73 KiB 51.46 KiB -3.28 KiB
RUM - start/stop session replay recording 23.65 KiB 23.84 KiB +194 B
RUM - start view 424.60 KiB 423.46 KiB -1.14 KiB
Logs - log message 43.70 KiB 42.94 KiB -776 B

🔗 RealWorld

@datadog-official
Copy link

datadog-official bot commented Dec 10, 2025

⚠️ Tests

⚠️ Warnings

❄️ 2 New flaky tests detected

cookie getCurrentSite caches the result from Safari 12.1.2 (Mac OS 10.14.6) (Datadog) (Fix with Cursor)
Expected spy cookie to have been called 2 times. It was called 0 times.
<Jasmine>
webpack:///packages/core/src/browser/cookie.spec.ts:50:43 <- /tmp/_karma_webpack_486751/commons.js:48710:49
<Jasmine>
cookie getCurrentSite returns the eTLD+1 for foo.bar.baz.example.com from Safari 12.1.2 (Mac OS 10.14.6) (Datadog) (Fix with Cursor)
Expected 'foo.bar.baz.example.com' to be 'example.com'.
<Jasmine>
webpack:///packages/core/src/browser/cookie.spec.ts:24:61 <- /tmp/_karma_webpack_486751/commons.js:48690:108
<Jasmine>

ℹ️ Info

🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 92.62% (+0.00%)

View detailed report

This comment will be updated automatically if new data arrives.
* Fix with Cursor requires Datadog plugin ≥v2.17.0
🔗 Commit SHA: bd371b5 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

sessionReplayEndpointBuilder: EndpointBuilder
profilingEndpointBuilder: EndpointBuilder
exposuresEndpointBuilder: EndpointBuilder
flagEvaluationEndpointBuilder: EndpointBuilder
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 thought: ‏I wonder if it is something that should live in core as exposures and flagEvaluation are not even used by the browser-sdk.
cc @BenoitZugmeyer

Copy link
Member

@BenoitZugmeyer BenoitZugmeyer Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, absolutely! I even gave it a try, and it's almost working! Not sure exactly why I stopped there, I was focusing on other tasks. In the meantime I accepted @lisaah PR to avoid blocking her, as I think this is benign and can be improved later.

cc @thomas-lebeau as you were also talking about this.

Copy link
Collaborator

@bcaudan bcaudan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lisaah lisaah merged commit 866ab07 into main Dec 11, 2025
22 checks passed
@lisaah lisaah deleted the lisa.huynh/add-flag-eval-endpoint-type branch December 11, 2025 14:43
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants