-
Notifications
You must be signed in to change notification settings - Fork 166
🎨 Add flagEvaluationEndpointBuilder to TransportConfiguration interface. #4025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
|
| sessionReplayEndpointBuilder: EndpointBuilder | ||
| profilingEndpointBuilder: EndpointBuilder | ||
| exposuresEndpointBuilder: EndpointBuilder | ||
| flagEvaluationEndpointBuilder: EndpointBuilder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💭 thought: I wonder if it is something that should live in core as exposures and flagEvaluation are not even used by the browser-sdk.
cc @BenoitZugmeyer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, absolutely! I even gave it a try, and it's almost working! Not sure exactly why I stopped there, I was focusing on other tasks. In the meantime I accepted @lisaah PR to avoid blocking her, as I think this is benign and can be improved later.
cc @thomas-lebeau as you were also talking about this.
bcaudan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation
Adds the flagEvaluationEndpointBuilder that was previously added to the configuration interface for accurate typing.
Changes
This is a type only change.
Test instructions
Checklist